Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Java 17 #1619

Closed
msaroufim opened this issue May 10, 2022 · 2 comments
Closed

Upgrade to Java 17 #1619

msaroufim opened this issue May 10, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@msaroufim
Copy link
Member

msaroufim commented May 10, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.

Java 17 has latency upgrades so it may be time to upgrade https://blogs.oracle.com/javamagazine/post/its-time-to-move-your-applications-to-java-17-heres-why-and-heres-how

Describe the solution

Update this to Java 17 https://github.com/pytorch/serve/blob/master/ts_scripts/install_dependencies.py#L139

We actually don't need a cask anymore either and can just run brew install openjdk@17
@msaroufim msaroufim added the enhancement New feature or request label May 13, 2022
@msaroufim msaroufim mentioned this issue May 21, 2022
Closed
@maaquib maaquib mentioned this issue Jun 15, 2022
Closed
This was referenced Jul 11, 2022
Closed
Closed
Closed
Closed
@rohithkrn
Copy link
Collaborator

rohithkrn commented Jul 11, 2022 •
edited
Loading

This was referenced Jul 14, 2022
Merged
Closed
Merged
@rohithkrn rohithkrn mentioned this issue Jul 25, 2022
Merged
2 tasks
@msaroufim
Copy link
Member Author

Thanks @rohithkrn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rohithkrn @msaroufim