Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update java version to 17 on ubuntu #1738

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Update java version to 17 on ubuntu #1738

merged 4 commits into from
Jul 19, 2022

Conversation

rohithkrn
Copy link
Collaborator

@rohithkrn rohithkrn commented Jul 14, 2022 •
edited
Loading

Description

Upgrades java version to 17 on ubuntu.

One notable change is that openjdk-17-jdk instead of just headless package due to circular dependency issue withca-certificate-java package. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1009905. This increased docker image size by ~200MB.

Docker images sizes:

ubuntu@ip-172-31-37-107:~/torchserve$ docker images
REPOSITORY             TAG              IMAGE ID       CREATED       SIZE
pytorch/torchserve     prod-cpu-jdk17   1cabb0c21a26   11 days ago   1.98GB
pytorch/torchserve     prod-gpu-jdk11   c507dc722994   11 days ago   7.56GB
pytorch/torchserve     prod-cpu-jdk11   f77c9b66469c   12 days ago   1.54GB
pytorch/torchserve     dev-gpu-jdk11    cd68df3b8f75   12 days ago   10.5GB
pytorch/torchserve     prod-gpu-jdk17   8a0adb614cae   12 days ago   8GB
pytorch/torchserve     dev-gpu-jdk17    2fee84b17735   13 days ago   10.6GB

Fixes #(issue)
#1619
sub task - #1730

Feature/Issue validation/testing

Test commands ran for above docker tests - test_commands.log

@rohithkrn rohithkrn requested review from lxning and maaquib July 15, 2022 04:19
@chauhang
Copy link
Contributor

@rohithkrn Can you please link up the benchmarks comparison test results?

@rohithkrn
Copy link
Collaborator Author

rohithkrn commented Jul 18, 2022 •
edited
Loading

@rohithkrn Can you please link up the benchmarks comparison test results?

@chauhang I linked the results above in performance test results.
https://gist.github.com/rohithkrn/992d3c3ca517d2131f559c80ed6086c9

rohithkrn
rohithkrn commented Jul 19, 2022
View reviewed changes
frontend/gradle/wrapper/gradle-wrapper.properties
@@ -1,5 +1,5 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-6.4-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-7.3-bin.zip
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.gradle.org/current/userguide/compatibility.html

@lxning
Copy link
Collaborator

lxning commented Jul 19, 2022

@rohithkrn could you post both dev and prod docker test log which includes docker image size, and run container)?

lxning
lxning reviewed Jul 19, 2022
View reviewed changes
docker/Dockerfile
@@ -34,7 +34,7 @@ RUN --mount=type=cache,id=apt-dev,target=/var/cache/apt \
python3.8-distutils \
python3.8-venv \
python3-venv \
openjdk-11-jre-headless \
openjdk-17-jdk \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add comments (eg. link of the jdk headless ca-certificate issue) at here so that we can follow later?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated.

maaquib
maaquib reviewed Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@maaquib maaquib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple of questions:

  • Are we planning to update the jdk in the github actions as part of a separate PR?
  • There are other Dockerfiles which should also be updated, I am fine with doin it as a separate PR (docker/Dockerfile.neuron.dev, kubernetes/kserve/Dockerfile.dev)

@rohithkrn
Copy link
Collaborator Author

@rohithkrn could you post both dev and prod docker test log which includes docker image size, and run container)?

Added logs and image sizes in the PR description(testing section) @lxning

@rohithkrn
Copy link
Collaborator Author

rohithkrn commented Jul 19, 2022 •
edited
Loading

LGTM. Couple of questions:

  • Are we planning to update the jdk in the github actions as part of a separate PR?
  • There are other Dockerfiles which should also be updated, I am fine with doin it as a separate PR (docker/Dockerfile.neuron.dev, kubernetes/kserve/Dockerfile.dev)

@maaquib

  • Yes, planning to update github actions in a separate PR
  • Did not include neuron and kserve chages as I hadn't tested for them. Will test and create separate PR.

@msaroufim msaroufim self-requested a review July 19, 2022 23:29
@msaroufim msaroufim merged commit 0db95ee into pytorch:master Jul 19, 2022
rohithkrn added a commit to rohithkrn/serve that referenced this pull request Jul 20, 2022
@rohithkrn
Update java version to 17 on ubuntu (pytorch#1738)
de7b54d 
* update java version to 17 on ubuntu

* fix unrelated lint error

* pre-commit run on install_dependencies to fix linting

* add comments for jdk debian package bug and lint

Co-authored-by: Rohith Nallamaddi <nalrohit@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lxning lxning lxning approved these changes

@msaroufim msaroufim msaroufim approved these changes

@maaquib maaquib maaquib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rohithkrn @chauhang @lxning @maaquib @msaroufim