-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an example of using fsspec for large batch inference #1927
Conversation
examples/cloud_storage_stream_inference/Download_Transformer_models.py
Outdated
Show resolved
Hide resolved
@kirkpa Thanks for the PR. This is great. Please check https://github.com/serve/blob/master/CONTRIBUTING.md and make sure to run the precommit command for lint |
Codecov Report
@@ Coverage Diff @@
## master #1927 +/- ##
=======================================
Coverage 44.95% 44.95%
=======================================
Files 63 63
Lines 2609 2609
Branches 56 56
=======================================
Hits 1173 1173
Misses 1436 1436 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@kirkpa This is a great contribution. could you please provide a test log for this example? Thanks. |
I've provided snippet of the output generated when running the example in README.md. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
…1927) * Adding cloud storage stream inference * working python example code * Updated README * Updated README * Addressing code review comments * Fixing lint errors * pre-commit updates * fixed spelling
…1927) * Adding cloud storage stream inference * working python example code * Updated README * Updated README * Addressing code review comments * Fixing lint errors * pre-commit updates * fixed spelling
Description
This change adds an example of using fsspec to retrieve data from cloud storage for batch inference using large batch size.
Addresses #1891
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
No testing required since this is adding an example. Instructions to run the example provided in README.md.