-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include torch-tensorrt in dev container #2789
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sachanub We need to think how we want to test this.
Currently, this test won't get executed anywhere?
Can you please create a nightly workflow to test the "dev" image.
Hi @agunapal I have modified the nightly docker regression test workflow to run tests for the dev container (IPEX and CUDA 12.1). I have included the test logs in the PR description. |
Hi @sachanub I'm not sure if we should be combining this with the prod workflow. Thinking in terms of integration with other libraries and may be we want to run this once a week. |
Description
Please read our CONTRIBUTING.md prior to creating your first pull request.
Please include a summary of the feature or issue being fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
The objective of this PR is to install
tensorrt
andtorch-tensorrt
in the TorchServe dev container. The following changes have been made:tensorrt
andtorch-tensorrt
if$CUDA_VERSION
is not empty.torch-model-archiver
.build_image.sh
script:nvidia/cuda:11.8.0-base-ubuntu20.04
.nvidia/cuda:11.6.2-cudnn8-runtime-ubuntu20.04
. The old one i.e.nvidia/cuda:11.6.0-cudnn8-runtime-ubuntu20.04
is no longer available on Docker hub.nvidia/cuda:11.3.1-cudnn8-runtime-ubuntu20.04
. The old one i.e.nvidia/cuda:11.3.0-cudnn8-runtime-ubuntu20.04
is no longer available on Docker hub.UPDATE:
Dockerfile
to run regression tests in the Docker regression test workflow.regression_tests_docker.yml
to build dev CI image (IPEX for CPU and CUDA 12.1 for GPU) and run regression tests.build_image.sh
script to supportdev-ci
option.torch-tensorrt==2.1.0
.Fixes #(issue)
Type of change
Please delete options that are not relevant.
Feature/Issue validation/testing
Please describe the Unit or Integration tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Ran regression tests in CPU, CUDA 11.8 and CUDA 12.1 dev CI images.
CUDA 12.1 dev CI image: https://github.com/pytorch/serve/actions/runs/6883668921/job/18724674984?pr=2789