Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AOTInductor BERT CPP example #2931
AOTInductor BERT CPP example #2931
Changes from 34 commits
ab41f43
f833d48
9f85b38
b1fadca
b430116
0addfff
e64ef7d
ce0e65a
ceacda0
e827f2f
d0315a6
2692dd2
92a6238
94d4309
fd5e145
203f19e
0d8f505
45ae6b2
558df11
9c2cdf3
a7a551f
748b734
0bbfc18
472df28
4b2a1ce
0604533
9922a99
0e81e4f
ac08078
869b9a3
294175e
d6fa808
c33f66c
caa5042
d39ba51
0e1d773
f8c71d4
be81439
71deb70
ebbf119
df861f1
a0c710b
20d8799
6accaf4
ee74ad9
9b67364
9c1a33a
9ab5336
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to create a submodule in third-party directly instead of cloning it manually. That way we freeze a specific commit and nothing breaks if the tokenizer-cpp repo gets updated. See llama2.so for example. git submodule update --init --recursive is executed in build.sh for all our submodules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will better fit into the cpp section of ts_scripts/install_dependencies.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link the issue or PR here that describes the problem in 2.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we saving the model here? Its already in the hub cache so no need to save it again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To not be misleading we should change this into "... for torch export"