-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI and Regression workflows for MAC Arm64 #3128
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namannandan
force-pushed
the
fix-mac-ci
branch
7 times, most recently
from
May 1, 2024 23:48
909bb6f
to
ec18c37
Compare
namannandan
changed the title
Update ci and regression cpu workflow for MAC
Fix CI and Regression workflows for MAC Arm64
May 6, 2024
mreso
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Mac CI and regression failures are being caused by the following reasons:
macos-lastest
github runner tag now points toarm64
based Mac.x86
Mac.Add GPU Passthrough (Metal) for GitHub-hosted macOS runners actions/runner-images#7085
GitHub Action: New M1 runner available to all plans, including open source 🚀 actions/runner-images#9254 (comment)
This PR fixes the above issues by:
Type of change
Feature/Issue validation/testing
arm64
CI: https://github.com/pytorch/serve/actions/runs/8976048758/job/24652034356?pr=3128arm64
Regression: https://github.com/pytorch/serve/actions/runs/8976048741/job/24652042161?pr=3128