Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Torch 1.13 compat #424

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[BugFix] Torch 1.13 compat #424

merged 1 commit into from
Jun 14, 2023

Conversation

vmoens
Copy link
Contributor

@vmoens vmoens commented Jun 14, 2023

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 14, 2023
@vmoens vmoens merged commit 4d679e4 into main Jun 14, 2023
@vmoens vmoens deleted the torch113_compat branch June 14, 2023 15:42
@github-actions
Copy link

$\color{#35bf28}\textsf{\Large✔\kern{0.2cm}\normalsize OK}$ Result of GPU Benchmark Tests

Total Benchmarks: 47. Improved: $\large\color{#35bf28}2$. Worsened: $\large\color{#d91a1a}0$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_common_ops 0.9627ms 0.9301ms 1.0751 KOps/s 1.1013 KOps/s $\color{#d91a1a}-2.38\%$
test_creation 3.7020μs 3.3796μs 295.8926 KOps/s 302.6877 KOps/s $\color{#d91a1a}-2.24\%$
test_creation_empty 9.6421μs 9.1419μs 109.3860 KOps/s 109.1746 KOps/s $\color{#35bf28}+0.19\%$
test_creation_nested_1 18.9901μs 16.4823μs 60.6711 KOps/s 61.2527 KOps/s $\color{#d91a1a}-0.95\%$
test_creation_nested_2 18.3651μs 17.5785μs 56.8876 KOps/s 56.8473 KOps/s $\color{#35bf28}+0.07\%$
test_clone 23.6342μs 21.8544μs 45.7574 KOps/s 46.5101 KOps/s $\color{#d91a1a}-1.62\%$
test_getitem[int] 27.2194μs 26.1405μs 38.2548 KOps/s 38.1632 KOps/s $\color{#35bf28}+0.24\%$
test_getitem[slice_int] 57.6482μs 54.1274μs 18.4749 KOps/s 18.0955 KOps/s $\color{#35bf28}+2.10\%$
test_getitem[range] 64.5591μs 59.8119μs 16.7191 KOps/s 16.9251 KOps/s $\color{#d91a1a}-1.22\%$
test_getitem[tuple] 52.5043μs 51.1427μs 19.5531 KOps/s 19.8968 KOps/s $\color{#d91a1a}-1.73\%$
test_getitem[list] 58.1982μs 53.1846μs 18.8024 KOps/s 19.1470 KOps/s $\color{#d91a1a}-1.80\%$
test_setitem_dim[int] 97.5010μs 39.3992μs 25.3812 KOps/s 25.0227 KOps/s $\color{#35bf28}+1.43\%$
test_setitem_dim[slice_int] 0.1052ms 70.3233μs 14.2200 KOps/s 13.9644 KOps/s $\color{#35bf28}+1.83\%$
test_setitem_dim[range] 0.1569ms 70.0382μs 14.2779 KOps/s 14.3315 KOps/s $\color{#d91a1a}-0.37\%$
test_setitem_dim[tuple] 0.1202ms 63.7878μs 15.6770 KOps/s 15.3902 KOps/s $\color{#35bf28}+1.86\%$
test_setitem 27.8162μs 26.2728μs 38.0622 KOps/s 38.0849 KOps/s $\color{#d91a1a}-0.06\%$
test_set 27.5292μs 25.8075μs 38.7484 KOps/s 39.0046 KOps/s $\color{#d91a1a}-0.66\%$
test_set_shared 0.1563ms 0.1518ms 6.5894 KOps/s 6.6384 KOps/s $\color{#d91a1a}-0.74\%$
test_update 31.6722μs 28.2478μs 35.4009 KOps/s 36.1654 KOps/s $\color{#d91a1a}-2.11\%$
test_update_nested 43.8773μs 42.6385μs 23.4530 KOps/s 23.7254 KOps/s $\color{#d91a1a}-1.15\%$
test_set_nested 35.1053μs 33.3289μs 30.0040 KOps/s 30.3409 KOps/s $\color{#d91a1a}-1.11\%$
test_set_nested_new 47.6604μs 46.4503μs 21.5284 KOps/s 21.5495 KOps/s $\color{#d91a1a}-0.10\%$
test_select 85.1506μs 75.2784μs 13.2840 KOps/s 13.1517 KOps/s $\color{#35bf28}+1.01\%$
test_creation[device0] 1.2973ms 0.5100ms 1.9607 KOps/s 1.6970 KOps/s $\textbf{\color{#35bf28}+15.54\%}$
test_creation_from_tensor 0.5839ms 0.4709ms 2.1235 KOps/s 2.1048 KOps/s $\color{#35bf28}+0.89\%$
test_add_one[memmap_tensor0] 35.7773μs 29.9540μs 33.3845 KOps/s 34.0880 KOps/s $\color{#d91a1a}-2.06\%$
test_contiguous[memmap_tensor0] 8.7301μs 8.1087μs 123.3249 KOps/s 123.2618 KOps/s $\color{#35bf28}+0.05\%$
test_stack[memmap_tensor0] 0.2096ms 46.5104μs 21.5006 KOps/s 21.8577 KOps/s $\color{#d91a1a}-1.63\%$
test_reshape_pytree 31.1822μs 28.0720μs 35.6226 KOps/s 35.4857 KOps/s $\color{#35bf28}+0.39\%$
test_reshape_td 43.1773μs 39.9519μs 25.0301 KOps/s 25.2652 KOps/s $\color{#d91a1a}-0.93\%$
test_view_pytree 27.8472μs 26.3523μs 37.9474 KOps/s 38.1331 KOps/s $\color{#d91a1a}-0.49\%$
test_view_td 8.1161μs 7.0490μs 141.8644 KOps/s 144.7184 KOps/s $\color{#d91a1a}-1.97\%$
test_unbind_pytree 31.8902μs 30.1772μs 33.1376 KOps/s 33.4300 KOps/s $\color{#d91a1a}-0.87\%$
test_unbind_td 0.1361ms 0.1224ms 8.1728 KOps/s 8.2964 KOps/s $\color{#d91a1a}-1.49\%$
test_split_pytree 36.5203μs 34.2425μs 29.2035 KOps/s 29.2239 KOps/s $\color{#d91a1a}-0.07\%$
test_split_td 99.6807μs 95.9521μs 10.4219 KOps/s 10.6304 KOps/s $\color{#d91a1a}-1.96\%$
test_add_pytree 39.9543μs 37.5665μs 26.6195 KOps/s 27.1642 KOps/s $\color{#d91a1a}-2.01\%$
test_add_td 55.8904μs 53.0923μs 18.8351 KOps/s 19.3399 KOps/s $\color{#d91a1a}-2.61\%$
test_distributed 89.4000μs 89.4000μs 11.1857 KOps/s 9.1074 KOps/s $\textbf{\color{#35bf28}+22.82\%}$
test_tdmodule 0.1196ms 21.5504μs 46.4029 KOps/s 47.5460 KOps/s $\color{#d91a1a}-2.40\%$
test_tdmodule_dispatch 0.2157ms 47.6443μs 20.9889 KOps/s 21.7818 KOps/s $\color{#d91a1a}-3.64\%$
test_tdseq 88.6010μs 29.5052μs 33.8923 KOps/s 33.9397 KOps/s $\color{#d91a1a}-0.14\%$
test_tdseq_dispatch 0.1161ms 56.7477μs 17.6219 KOps/s 17.9774 KOps/s $\color{#d91a1a}-1.98\%$
test_instantiation_functorch 1.3765ms 1.2952ms 772.0828 Ops/s 789.5819 Ops/s $\color{#d91a1a}-2.22\%$
test_instantiation_td 1.0593ms 1.0046ms 995.4196 Ops/s 1.0235 KOps/s $\color{#d91a1a}-2.74\%$
test_exec_functorch 0.2061ms 0.1601ms 6.2479 KOps/s 6.3896 KOps/s $\color{#d91a1a}-2.22\%$
test_exec_td 0.1979ms 0.1941ms 5.1524 KOps/s 5.2936 KOps/s $\color{#d91a1a}-2.67\%$

@github-actions
Copy link

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 47. Improved: $\large\color{#35bf28}12$. Worsened: $\large\color{#d91a1a}6$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_common_ops 2.0138ms 1.6500ms 606.0591 Ops/s 603.8272 Ops/s $\color{#35bf28}+0.37\%$
test_creation 28.0831μs 4.9608μs 201.5818 KOps/s 170.9570 KOps/s $\textbf{\color{#35bf28}+17.91\%}$
test_creation_empty 67.5362μs 16.7963μs 59.5369 KOps/s 77.3740 KOps/s $\textbf{\color{#d91a1a}-23.05\%}$
test_creation_nested_1 83.9573μs 29.6397μs 33.7385 KOps/s 37.9861 KOps/s $\textbf{\color{#d91a1a}-11.18\%}$
test_creation_nested_2 46.9701μs 27.1281μs 36.8621 KOps/s 39.5460 KOps/s $\textbf{\color{#d91a1a}-6.79\%}$
test_clone 75.3672μs 37.6481μs 26.5617 KOps/s 23.6329 KOps/s $\textbf{\color{#35bf28}+12.39\%}$
test_getitem[int] 61.3864μs 47.2909μs 21.1457 KOps/s 21.1535 KOps/s $\color{#d91a1a}-0.04\%$
test_getitem[slice_int] 0.1527ms 0.1038ms 9.6350 KOps/s 9.7638 KOps/s $\color{#d91a1a}-1.32\%$
test_getitem[range] 0.1554ms 0.1227ms 8.1472 KOps/s 7.6847 KOps/s $\textbf{\color{#35bf28}+6.02\%}$
test_getitem[tuple] 0.1204ms 90.9147μs 10.9993 KOps/s 11.2803 KOps/s $\color{#d91a1a}-2.49\%$
test_getitem[list] 0.1396ms 0.1077ms 9.2810 KOps/s 8.9309 KOps/s $\color{#35bf28}+3.92\%$
test_setitem_dim[int] 1.5059ms 74.2423μs 13.4694 KOps/s 13.3394 KOps/s $\color{#35bf28}+0.97\%$
test_setitem_dim[slice_int] 3.2172ms 0.1409ms 7.0979 KOps/s 7.3560 KOps/s $\color{#d91a1a}-3.51\%$
test_setitem_dim[range] 3.2114ms 0.1376ms 7.2648 KOps/s 7.2660 KOps/s $\color{#d91a1a}-0.02\%$
test_setitem_dim[tuple] 5.3547ms 0.1178ms 8.4872 KOps/s 8.2684 KOps/s $\color{#35bf28}+2.65\%$
test_setitem 77.0814μs 46.9176μs 21.3140 KOps/s 18.5081 KOps/s $\textbf{\color{#35bf28}+15.16\%}$
test_set 67.5643μs 48.6527μs 20.5539 KOps/s 19.8870 KOps/s $\color{#35bf28}+3.35\%$
test_set_shared 0.3693ms 0.2773ms 3.6062 KOps/s 3.3088 KOps/s $\textbf{\color{#35bf28}+8.99\%}$
test_update 85.8083μs 54.3614μs 18.3954 KOps/s 18.5287 KOps/s $\color{#d91a1a}-0.72\%$
test_update_nested 0.1085ms 81.5044μs 12.2693 KOps/s 12.5193 KOps/s $\color{#d91a1a}-2.00\%$
test_set_nested 0.1085ms 63.8466μs 15.6626 KOps/s 14.7211 KOps/s $\textbf{\color{#35bf28}+6.40\%}$
test_set_nested_new 0.1391ms 85.7972μs 11.6554 KOps/s 11.1584 KOps/s $\color{#35bf28}+4.45\%$
test_select 0.2012ms 0.1385ms 7.2188 KOps/s 7.1407 KOps/s $\color{#35bf28}+1.09\%$
test_creation[device0] 1.8546ms 0.6616ms 1.5116 KOps/s 1.9136 KOps/s $\textbf{\color{#d91a1a}-21.01\%}$
test_creation_from_tensor 0.6456ms 0.5259ms 1.9015 KOps/s 1.9788 KOps/s $\color{#d91a1a}-3.91\%$
test_add_one[memmap_tensor0] 0.1287ms 62.6164μs 15.9703 KOps/s 16.4700 KOps/s $\color{#d91a1a}-3.03\%$
test_contiguous[memmap_tensor0] 22.9931μs 10.8394μs 92.2560 KOps/s 86.7412 KOps/s $\textbf{\color{#35bf28}+6.36\%}$
test_stack[memmap_tensor0] 0.2101ms 56.4502μs 17.7147 KOps/s 14.0686 KOps/s $\textbf{\color{#35bf28}+25.92\%}$
test_reshape_pytree 67.6792μs 40.7931μs 24.5140 KOps/s 21.8507 KOps/s $\textbf{\color{#35bf28}+12.19\%}$
test_reshape_td 0.1084ms 65.0608μs 15.3702 KOps/s 14.0435 KOps/s $\textbf{\color{#35bf28}+9.45\%}$
test_view_pytree 79.6222μs 38.9441μs 25.6779 KOps/s 24.1810 KOps/s $\textbf{\color{#35bf28}+6.19\%}$
test_view_td 42.2781μs 11.3393μs 88.1890 KOps/s 93.0489 KOps/s $\textbf{\color{#d91a1a}-5.22\%}$
test_unbind_pytree 65.3792μs 44.0627μs 22.6950 KOps/s 23.7439 KOps/s $\color{#d91a1a}-4.42\%$
test_unbind_td 0.2875ms 0.2225ms 4.4945 KOps/s 4.6946 KOps/s $\color{#d91a1a}-4.26\%$
test_split_pytree 74.7802μs 50.9365μs 19.6323 KOps/s 19.0647 KOps/s $\color{#35bf28}+2.98\%$
test_split_td 0.2484ms 0.1726ms 5.7928 KOps/s 6.0028 KOps/s $\color{#d91a1a}-3.50\%$
test_add_pytree 93.0363μs 70.0472μs 14.2761 KOps/s 14.0662 KOps/s $\color{#35bf28}+1.49\%$
test_add_td 0.1653ms 0.1180ms 8.4780 KOps/s 8.7841 KOps/s $\color{#d91a1a}-3.48\%$
test_distributed 86.6000μs 86.6000μs 11.5473 KOps/s 9.5328 KOps/s $\textbf{\color{#35bf28}+21.13\%}$
test_tdmodule 2.9482ms 40.3289μs 24.7961 KOps/s 25.8286 KOps/s $\color{#d91a1a}-4.00\%$
test_tdmodule_dispatch 2.5308ms 80.8059μs 12.3753 KOps/s 12.3569 KOps/s $\color{#35bf28}+0.15\%$
test_tdseq 3.0031ms 53.4142μs 18.7216 KOps/s 19.6009 KOps/s $\color{#d91a1a}-4.49\%$
test_tdseq_dispatch 4.7377ms 94.6727μs 10.5627 KOps/s 11.0604 KOps/s $\color{#d91a1a}-4.50\%$
test_instantiation_functorch 2.9475ms 2.1288ms 469.7399 Ops/s 454.1310 Ops/s $\color{#35bf28}+3.44\%$
test_instantiation_td 10.4830ms 1.6801ms 595.1882 Ops/s 650.3275 Ops/s $\textbf{\color{#d91a1a}-8.48\%}$
test_exec_functorch 0.3680ms 0.2887ms 3.4640 KOps/s 3.5885 KOps/s $\color{#d91a1a}-3.47\%$
test_exec_td 0.5351ms 0.3701ms 2.7023 KOps/s 2.6964 KOps/s $\color{#35bf28}+0.22\%$

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants