Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add EnsembleModule #485

Merged
merged 4 commits into from
Jul 11, 2023
Merged

[Feature] Add EnsembleModule #485

merged 4 commits into from
Jul 11, 2023

Conversation

smorad
Copy link
Contributor

@smorad smorad commented Jul 11, 2023

Description

This enables the use of functional ensembles in tensordict. I'm having trouble building the docs, but I'm not doing anything crazy with the docs so it should "just work".

Motivation and Context

I moved pytorch/rl#1359 to the tensordict repo as it could be useful outside of RL scenarios. This makes progress on pytorch/rl#1344.

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
  • I have updated the documentation accordingly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 11, 2023
@smorad smorad mentioned this pull request Jul 11, 2023
10 tasks
@vmoens vmoens changed the title Add EnsembleModule [Feature] Add EnsembleModule Jul 11, 2023
@vmoens vmoens added the enhancement New feature or request label Jul 11, 2023
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks for this
One minor thing regarding headers and we're good to merge (if tests pass)

tensordict/nn/ensemble.py Show resolved Hide resolved
@vmoens
Copy link
Contributor

vmoens commented Jul 11, 2023

Also: can you fix the lint with pre-commit?

@vmoens vmoens merged commit eab4d5c into pytorch:main Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants