Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Fix doc CI #489

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[CI] Fix doc CI #489

merged 1 commit into from
Jul 18, 2023

Conversation

matteobettini
Copy link
Contributor

No description provided.

@matteobettini
fix doc ci
1716c78 
Signed-off-by: Matteo Bettini <matbet@meta.com>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 17, 2023
@matteobettini
Copy link
Contributor Author

@vmoens we may also want the stuff from the rl pr regarding filing and exposing the artifacts

@vmoens vmoens added documentation Improvements or additions to documentation CI labels Jul 18, 2023
vmoens
vmoens approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens
Copy link
Contributor

vmoens commented Jul 18, 2023

@vmoens we may also want the stuff from the rl pr regarding filing and exposing the artifacts

As in: moving files to s3? Sure we can do that in a follow up

@vmoens vmoens merged commit 6242249 into pytorch:main Jul 18, 2023
@matteobettini
Copy link
Contributor Author

It was more about the possibility of building the doc and downloading the artifacts from the ci but yes we can do later

@matteobettini matteobettini deleted the fix_doc_ci branch July 18, 2023 21:49
@matteobettini
Copy link
Contributor Author

Actually i think the CI of this PR was broken, we might wanna remove versions for mystpaser and docutils too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmoens vmoens vmoens approved these changes

Assignees
No one assigned
Labels
CI CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @vmoens @facebook-github-bot