[TorchFix] Add codemod for unsafe load #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4671 added linter-only
TorchUnsafeLoadVisitor, but it turned out that the issue is so widespread that manual fixes would be tedious.The codemod is somewhat unsafe correctness-wise because full pickling functionality may still be needed even without
pickle_module, but I think it's OK because it fixes a security-related issue and the codemods need to be verified anyway.Maybe later we should add something like Ruff's recently added
--unsafe-fixes: https://docs.astral.sh/ruff/linter/#fix-safetyI used this for pytorch/vision#8105