Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly return 200 in api/flaky-tests/disable #6184

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Jan 17, 2025

When investigating pytorch/pytorch#144964, I notice that api/flaky-tests/disable returns 403 error code even when I use the correct credential. Same goes on
https://vercel.com/fbopensource/torchci/logs?requestPaths=%2Fapi%2Fflaky-tests%2Fdisable&selectedLogId=cv6z2-1736966788286-ab32c5324f42&timeline=maximum&page=2

Verified

This commit was signed with the committer’s verified signature.
danepowell Dane Powell
@huydhn huydhn requested a review from clee2000 January 17, 2025 00:53
Copy link

vercel bot commented Jan 17, 2025

@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 17, 2025
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jan 17, 2025 1:36am

@huydhn huydhn merged commit a311036 into pytorch:main Jan 21, 2025
6 checks passed
Camyll pushed a commit that referenced this pull request Jan 21, 2025
When investigating pytorch/pytorch#144964, I
notice that `api/flaky-tests/disable` returns 403 error code even when I
use the correct credential. Same goes on

https://vercel.com/fbopensource/torchci/logs?requestPaths=%2Fapi%2Fflaky-tests%2Fdisable&selectedLogId=cv6z2-1736966788286-ab32c5324f42&timeline=maximum&page=2
huydhn added a commit that referenced this pull request Jan 21, 2025
Camyll pushed a commit that referenced this pull request Jan 22, 2025
Camyll pushed a commit that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants