Skip to content

Add Amazon EC2 M8g Instances #6642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Add Amazon EC2 M8g Instances #6642

merged 2 commits into from
May 27, 2025

Conversation

Mousius
Copy link
Contributor

@Mousius Mousius commented May 20, 2025

This would allow us to test on AWS Graviton4 processors.

Our intention is to add this alongside the existing AWS Graviton3 processors for unit tests.

@Mousius
Add Amazon EC2 M8g Instances
5009c8a 
This would allow us to test on AWS Graviton4 processors. Out intention is to add this alongside the existing AWS Graviton3 processors for unit tests.
@vercel Vercel
Copy link

vercel bot commented May 20, 2025

@Mousius is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 20, 2025
@Mousius Mousius mentioned this pull request May 20, 2025
Open
@fadara01
Copy link

@zxiiro could you please help approve the awaiting CI workflows and the deployment?

@zxiiro
Copy link
Collaborator

zxiiro commented May 26, 2025

@zxiiro could you please help approve the awaiting CI workflows and the deployment?

You'll need to add similar changes to all the *-scale-config.yml files to pass validation.

@Mousius
Copy link
Contributor Author

Mousius commented May 26, 2025

@zxiiro sorry about that, ran the script now 😸

@Mousius
Copy link
Contributor Author

Mousius commented May 26, 2025

@zxiiro scale-config.yml references changes for pytorch/pytorch, I don't see any new files, where do I find those?

@zxiiro
Copy link
Collaborator

zxiiro commented May 26, 2025

@zxiiro scale-config.yml references changes for pytorch/pytorch, I don't see any new files, where do I find those?

That maybe an out of date reference. To my knowledge I don't think there's any scale-configs in pytorch/pytorch today.

@Mousius
Copy link
Contributor Author

Mousius commented May 27, 2025

@zxiiro is this now good to go then?

@zxiiro
Copy link
Collaborator

zxiiro commented May 27, 2025

Looks good to me.

@zxiiro zxiiro merged commit 6a14216 into pytorch:main May 27, 2025
4 of 5 checks passed
@Mousius Mousius deleted the add-m8g branch May 27, 2025 13:51
pytorch-bot bot pushed a commit to pytorch/pytorch that referenced this pull request May 28, 2025
@Mousius
Run tests on Amazon EC2 M8g Instances
517cc9d 
Requires machines configured here: pytorch/test-infra#6642

This adds additional test runs against AWS Graviton4 processors, alongside existing runs against AWS Graviton3 and AWS Graviton2 processors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxiiro zxiiro zxiiro approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mousius @fadara01 @zxiiro @facebook-github-bot