-
Notifications
You must be signed in to change notification settings - Fork 106
Add vLLM CI metrics #7239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vLLM CI metrics #7239
Conversation
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
|
As there are questions from @jeanschmidt @zhewenl and @rzabarazesh in the context of vllm-project/vllm#25670, I want to share my thoughts on how this fits into GHA migration journey:
|
|
Optional:L when hover on the chart, is not very clear which color represented which |
|
Probably good to add some description about the metrics too in the ui |
We will need trunk health metric like what is available on https://app.hex.tech/533fe68e-dcd8-4a52-a101-aefba762f581/app/vLLM-CI-030kdEgDv6lSlh1UPYOkWP/latest to supplement these metrics here. Take an example, the signals from vllm-project/vllm#25706 merged 3 hours ago was a-ok, but its trunk commit failed vllm-project/vllm@d5ab285. The discrepancy you see could mean 2 things:
|
Signed-off-by: Huy Do <huydhn@gmail.com>


This PR has two parts, the query
vllm/merges_percentageand a new HUD pagemetrics/vllm.tsxto display vLLM CI metrics. There are 2 KPIs to start with:What is a vLLM CI failure?
As vLLM CI is on Buildkite, a CI failure means a failed Buildkite job that (1) is not a soft fail, and (2) fails on its latest retry at the time of the merge. We can get this information by joining the GitHub
pull_requestwith Buildkitevllm_buildkite_jobson the pull request number.Testing
https://torchci-git-vllm-metrics-fbopensource.vercel.app/metrics/vllm
cc @rzabarazesh @yeqcharlotte @simon-mo