Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing __contains__ for vocab.Vectors class #2140

Closed
saeeddhqan opened this issue Apr 4, 2023 · 2 comments · Fixed by #2144
Closed

Implementing __contains__ for vocab.Vectors class #2140

saeeddhqan opened this issue Apr 4, 2023 · 2 comments · Fixed by #2144

Comments

@saeeddhqan
Copy link
Contributor

saeeddhqan commented Apr 4, 2023 •
edited
Loading

🚀 Feature

Isn't it better to implement __contains__ for Vectors class? In this way, one can easily find out whether a vocab is in the self.itos or not.
@joecummings
Copy link
Contributor

Thanks for opening an issue @saeeddhqan! If you want to propose this feature, we can help with testing and approving.

@saeeddhqan
Copy link
Contributor Author

I created the PR. Looking forward to hear from you!

@Nayef211 Nayef211 mentioned this issue Apr 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implementing __contains__ for vocab.Vectors class saeeddhqan/text
2 participants
@joecummings @saeeddhqan