Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing __contains__ for vocab.Vectors class #2144

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

saeeddhqan
Copy link
Contributor

@saeeddhqan saeeddhqan commented Apr 5, 2023

Thank you for taking your time. This is my first contribution to this project.
I implemented the method. If I need to change any documentation or anything else, do let me know.

Thanks!

Closes #2140

Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Thanks for the contribution @saeeddhqan 😄

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/codeql.yml:build. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@joecummings joecummings merged commit f3c34f9 into pytorch:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing __contains__ for vocab.Vectors class
4 participants