Add __setitem__ func to torchtext.experimental.vocab.Vocab #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
October 9, 2020 06:47
added 19 commits
October 19, 2020 13:21
Codecov Report
@@ Coverage Diff @@
## master #1113 +/- ##
==========================================
+ Coverage 79.46% 79.52% +0.06%
==========================================
Files 47 47
Lines 3175 3185 +10
==========================================
+ Hits 2523 2533 +10
Misses 652 652
Continue to review full report at Codecov.
|
…ting token. They have to delete it before reassignment.
zhangguanheng66
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1027
Add
__setitem__func to torchtext.experimental.vocab.Vocab. A__delitem__func is added as well.[RuntimeError] if the token exists, a error message is sent out and ask users to delete the existing token from vocab.
Note: for the vocab, we don't support the assignment between a single index and multiple tokens.