Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace model with full name when spacy load is used #1140

Merged
merged 3 commits into from
Feb 4, 2021
Merged

Replace model with full name when spacy load is used #1140

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
922221c
Replace model with full name when spacy load is used
malfet Feb 4, 2021
d8b9a03
Add warning
malfet Feb 4, 2021
c9010a1
Update torchtext/data/utils.py
cpuhrsch Feb 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion torchtext/data/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,17 @@ def get_tokenizer(tokenizer, language='en'):
if tokenizer == "spacy":
try:
import spacy
spacy = spacy.load(language)
try:
spacy = spacy.load(language)
except IOError:
# Model shortcuts no longer work in spaCy 3.0+, try using fullnames
# List is from https://github.com/explosion/spaCy/blob/b903de3fcb56df2f7247e5b6cfa6b66f4ff02b62/spacy/errors.py#L789
OLD_MODEL_SHORTCUTS = spacy.errors.OLD_MODEL_SHORTCUTS if hasattr(spacy.errors, 'OLD_MODEL_SHORTCUTS') else {}
if language not in OLD_MODEL_SHORTCUTS:
cpuhrsch marked this conversation as resolved.
Show resolved Hide resolved
raise
import warnings
warnings.warn(f'Spacy model "{language}" could not be loaded, trying "{OLD_MODEL_SHORTCUTS[language]}" instead')
spacy = spacy.load(OLD_MODEL_SHORTCUTS[language])
return partial(_spacy_tokenize, spacy=spacy)
except ImportError:
print("Please install SpaCy. "
Expand Down