Add _PATHS to text classification datasets, add global MD5 and NUM_LINES #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult already exists. Create global MD5 and NUM_LINES dictionaries.
Codecov Report
@@ Coverage Diff @@
## master #1155 +/- ##
==========================================
+ Coverage 79.46% 79.61% +0.14%
==========================================
Files 47 47
Lines 3175 3198 +23
==========================================
+ Hits 2523 2546 +23
Misses 652 652
Continue to review full report at Codecov.
|
cpuhrsch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently text classification datasets will download from google drive even if the result already exists on disk, because google drive URLs do not allow to infer the path at which the download result will be stored. This PR addresses this for translation datasets and further introduces torchtext.experimental.datasets.raw.MD5 and NUM_LINES dictionaries to allow for easier access of this meta information. It also fixes meta information for the wrapped dataset factory function to actually contain the defaults for split, root and offset.