Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WMTNewsCrawl dataset back to the experimental folder because the URL link is very slow #1202

Merged
merged 13 commits into from
Feb 23, 2021

Conversation

zhangguanheng66
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 commented Feb 22, 2021

TODO:

  • Create test in test/experimental for this

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1202 (fbd1f51) into master (22ba68d) will increase coverage by 0.17%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1202      +/-   ##
==========================================
+ Coverage   73.04%   73.21%   +0.17%     
==========================================
  Files          66       67       +1     
  Lines        3676     3689      +13     
==========================================
+ Hits         2685     2701      +16     
+ Misses        991      988       -3     
Impacted Files Coverage Δ
torchtext/datasets/__init__.py 100.00% <ø> (ø)
...rchtext/experimental/datasets/language_modeling.py 93.33% <50.00%> (+0.11%) ⬆️
torchtext/experimental/datasets/raw/__init__.py 100.00% <100.00%> (ø)
...orchtext/experimental/datasets/raw/wmtnewscrawl.py 70.83% <100.00%> (ø)
torchtext/legacy/data/dataset.py 93.90% <0.00%> (ø)
torchtext/nn/modules/multiheadattention.py 92.40% <0.00%> (ø)
torchtext/legacy/datasets/language_modeling.py 90.38% <0.00%> (ø)
torchtext/data/datasets_utils.py 91.86% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22ba68d...770d2c4. Read the comment docs.

@zhangguanheng66 zhangguanheng66 merged commit 6a6e9c8 into pytorch:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants