Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GPT-2 BPE pre-tokenizer operator leveraging re2 regex library #1459
Add GPT-2 BPE pre-tokenizer operator leveraging re2 regex library #1459
Changes from 1 commit
69a065e
a6d6d6e
0404189
eef6a66
2e176c7
d23abb4
09b5784
26da71f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: nit: I feel that the cyclomatic complexity of this main logic, almost hitting the threshold. (though it's not like I calculated or anything), so if, in the future, any update is made, I suggest to consider refactoring. (I understand it's not straight forward though.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. I don't expect this to change in future. If any changes occur in logic. I will try to abstract the logic out in an auxiliary self-contained method.