Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix optionality of default arg #1475

Merged
merged 1 commit into from
Jan 3, 2022
Merged

fix optionality of default arg #1475

merged 1 commit into from
Jan 3, 2022

Conversation

erip
Copy link
Contributor

@erip erip commented Dec 31, 2021

No description provided.

@erip
Copy link
Contributor Author

erip commented Dec 31, 2021

Failure is unrelated

Nayef211
Nayef211 approved these changes Jan 2, 2022
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for correcting this @erip. Approved!

@parmeet parmeet merged commit be7bc66 into pytorch:main Jan 3, 2022
@erip erip deleted the patch-1 branch January 4, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erip @Nayef211 @parmeet @facebook-github-bot