Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SST2 Mocked Unit Test #1542

Merged
merged 6 commits into from
Jan 28, 2022
Merged

Add SST2 Mocked Unit Test #1542

merged 6 commits into from
Jan 28, 2022

Conversation

Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Jan 27, 2022 •
edited
Loading

Reference Issue: #1493

Summary

  • Added mocked unit test for SST dataset
  • Added zip_equal helper function to help test for unequal dataset lengths (stackoverflow thread)

Test

  • pytest test/datasets/test_sst2.py

Followup Items

  • Update AmazonReviewPolarity test to be consistent with changes in this PR

@Nayef211 Nayef211 mentioned this pull request Jan 27, 2022
Closed
27 tasks
@Nayef211 Nayef211 requested a review from mthrok January 27, 2022 21:15
mthrok
mthrok reviewed Jan 27, 2022
View reviewed changes
test/datasets/test_sst2.py Outdated Show resolved Hide resolved
test/datasets/test_sst2.py Outdated Show resolved Hide resolved
test/datasets/test_sst2.py Outdated Show resolved Hide resolved
test/datasets/test_sst2.py Outdated Show resolved Hide resolved
@Nayef211 Nayef211 requested a review from mthrok January 28, 2022 03:54
mthrok
mthrok approved these changes Jan 28, 2022
View reviewed changes
test/datasets/test_sst2.py Outdated Show resolved Hide resolved
parmeet
parmeet approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Nayef211 Nayef211 merged commit 7f839b6 into pytorch:main Jan 28, 2022
@Nayef211 Nayef211 mentioned this pull request Jan 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parmeet parmeet parmeet approved these changes

@mthrok mthrok mthrok approved these changes

@abhinavarora abhinavarora Awaiting requested review from abhinavarora

Assignees
No one assigned
Labels
ciflow/default cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nayef211 @mthrok @parmeet @facebook-github-bot