Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YelpReviewFull Mocked Unit Test #1568

Merged
merged 3 commits into from
Feb 3, 2022
Merged

Add YelpReviewFull Mocked Unit Test #1568

merged 3 commits into from
Feb 3, 2022

Conversation

vcm2114
Copy link
Contributor

@vcm2114 vcm2114 commented Feb 3, 2022

Reference Issue: #1493

Summary

  • Added mocked unit test for YelpReviewFull dataset

Test

  • pytest test/datasets/test_yelpreviewfull.py

@vcm2114 vcm2114 mentioned this pull request Feb 3, 2022
Closed
27 tasks
Nayef211
Nayef211 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! Thanks for helping with our dataset testing revamp efforts @VirgileHlav!

@vcm2114 vcm2114 merged commit 14fef0f into pytorch:main Feb 3, 2022
@vcm2114 vcm2114 mentioned this pull request Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vcm2114 @Nayef211 @facebook-github-bot