Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug-Fix] fix hash for datasets testing #1572

Merged
merged 2 commits into from
Feb 3, 2022
Merged

[Bug-Fix] fix hash for datasets testing #1572

merged 2 commits into from
Feb 3, 2022

Conversation

parmeet
Copy link
Contributor

@parmeet parmeet commented Feb 3, 2022 •
edited
Loading

This PR fixes the dataset hash in testing due the changes introduced in #1511 and #1512

Adresses comment #1559 (comment)

Nayef211
Nayef211 approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing the hashes @parmeet. I should have updated these when I migrated the 2 datasets. As a followup, I need to add the hashes for the SST2 dataset to this JSON file as well.

@parmeet parmeet merged commit 339804f into pytorch:main Feb 3, 2022
@parmeet parmeet deleted the fix_hash branch February 3, 2022 20:36
@Nayef211 Nayef211 mentioned this pull request Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 approved these changes

Assignees
No one assigned
Labels
ciflow/default cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parmeet @Nayef211 @facebook-github-bot