-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding MacOS unit tests on CircleCI #1672
Conversation
FYI: The setup script uses yaml file to list the environment. https://github.com/pytorch/text/blob/main/.circleci/unittest/linux/scripts/setup_env.sh#L39 This seems like a clean way to install the same set of packages, but it was disaster for macOS conda environments so audio stopped doing it. (Always getting UnsatisfiableDependencies error) |
I see so what was the workaround that you use in torchaudio to resolve this? |
Manually listing them. I wonder why YAML approach wouldn't work the same way... Maybe we had mis understanding of the situation. Because even with this approach, macOS conda dependencies are broken most of the time. |
Codecov Report
@@ Coverage Diff @@
## main #1672 +/- ##
=======================================
Coverage 89.29% 89.29%
=======================================
Files 51 51
Lines 2298 2298
=======================================
Hits 2052 2052
Misses 246 246 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I see green light on macOS tests, but just to be sure skim through the test log to see if there is any abnormality that are suppressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mthrok for the review and help in adding the tests. I just looked through the MacOS test logs and everything looked okay. Will merge this once all the CI jobs pass
Reference Issue #1644
Description
Testing