Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CoLA dataset with unit tests #1711

Merged
merged 10 commits into from
May 18, 2022

Conversation

vcm2114
Copy link
Contributor

@vcm2114 vcm2114 commented May 11, 2022

Summary

  • Added support for CoLA dataset
  • Added mocked unit tests for CoLA dataset

Test

  • pytest test/datasets/test_cola.py

Context

See #1710

Copy link
Contributor

@parmeet parmeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please fix the linter issue before merge. You could also install and configure pre-commit and run pre-commit run after staging files to ensure there are no linting issues.

torchtext/datasets/cola.py Outdated Show resolved Hide resolved
@vcm2114 vcm2114 merged commit ec20f88 into pytorch:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants