Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for QNLI dataset with unit tests #1717

Merged
merged 7 commits into from
Jun 1, 2022
Merged

Add support for QNLI dataset with unit tests #1717

merged 7 commits into from
Jun 1, 2022

Conversation

vcm2114
Copy link
Contributor

@vcm2114 vcm2114 commented May 11, 2022

Summary

  • Added support for QNLI dataset
  • Added mocked unit tests for QNLI dataset

Test

  • pytest test/datasets/test_qnli.py

Context

See #1710

@vcm2114 vcm2114 mentioned this pull request May 11, 2022
Closed
8 tasks
parmeet
parmeet reviewed May 13, 2022
View reviewed changes
test/datasets/test_qnli.py Outdated Show resolved Hide resolved
Nayef211
Nayef211 approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

torchtext/datasets/qnli.py Outdated Show resolved Hide resolved
@vcm2114 vcm2114 merged commit dc7325a into pytorch:main Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nayef211 Nayef211 Nayef211 approved these changes

@parmeet parmeet parmeet left review comments

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vcm2114 @parmeet @Nayef211 @facebook-github-bot