Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fbsync] Enable model testing in FBCode #1720

Merged
merged 1 commit into from
May 12, 2022

Conversation

parmeet
Copy link
Contributor

@parmeet parmeet commented May 12, 2022

Summary:
This diff enables Model testing in FB code

Notes:

  1. it only tests XLM-R models (base and large) in integration tests. We need to do a follow-up diff to enable RoBERTa testing since corresponding assets are missing in FBcode.

Edit: Addressed the Roberta model testing in this diff itself

  1. parameterized was giving some weird long names to the test which was creating some unknown issue for running them in sandcastlle. Removed it for now to get the proper names for test.

Edit: refactored test suit since nested_params was creating long string names (400+ characters) for test methods due to RobertaBundle objects

Reviewed By: mikekgfb

Differential Revision: D35973306

fbshipit-source-id: 8a50d03466f60c8a4a0fbd5857611e68c92ebf08

Summary:
This diff enables Model testing in FB code

Notes:
1. it only tests XLM-R models (base and large) in integration tests. We need to do a follow-up diff to enable RoBERTa testing since corresponding assets are missing in FBcode.

Edit: Addressed the Roberta model testing in this diff itself

2. parameterized was giving some weird long names to the test which was creating some unknown issue for running them in sandcastlle. Removed it for now to get the proper names for test.

Edit: refactored test suit since nested_params was creating long string names (400+ characters) for test methods due to RobertaBundle objects

Reviewed By: mikekgfb

Differential Revision: D35973306

fbshipit-source-id: 8a50d03466f60c8a4a0fbd5857611e68c92ebf08
Copy link
Contributor

@Nayef211 Nayef211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's discuss offline about how we want to do testing in the future to reduce code duplication. I think @mthrok may be interested in this as well.

@parmeet parmeet merged commit 6689502 into pytorch:main May 12, 2022
@parmeet parmeet deleted the fbsync_D35973306 branch May 12, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants