Torcharrow based training using RoBERTa model and SST2 classification dataset #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nayef211
reviewed
Jun 24, 2022
Nayef211
approved these changes
Jul 21, 2022
examples/torcharrow/README.md
Outdated
|
|
||
| #### TorchData | ||
|
|
||
| To install TorchData follow instructions athttps://github.com/pytorch/data#installation |
There was a problem hiding this comment.
nit: add a space after "at"
wenleix
reviewed
Jul 21, 2022
| # Add EOS token to the end of sentence | ||
| self.add_eos = T.AddToken(token=2, begin=False) | ||
|
|
||
| def forward(self, input: ta.DataFrame) -> ta.DataFrame: |
There was a problem hiding this comment.
We can probably just to have a standalone preproc function, similar to https://github.com/pytorch/torchrec/blob/20f543ee3700f2ebb27be6e80d636bd5dd0d7f3c/examples/torcharrow/dataloader.py#L59-L94
There was a problem hiding this comment.
SGTM, thanks for the suggestion @wenleix. Let me do a follow-up PR to do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example end-2-end training for RoBERTa model with TorchArrow based text pre-processing.