Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update xcode version to 14.0 in CI #1881

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Update xcode version to 14.0 in CI #1881

merged 1 commit into from
Aug 15, 2022

Conversation

Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Aug 15, 2022 •
edited
Loading

Description

  • CI jobs on MacOS have been failing with the following error message
failed to create host: Image xcode:12.5 is not supported
  • According to the CircleCI website, Xcode 12 will be deprecated once Xcode 15 reaches RC which is likely the cause for this failure
  • In this PR we bump the Xcode version to be 14.0 in line with torchvision

@Nayef211 Nayef211 changed the title [WIP] Update xcode version to 14.0 in CI Update xcode version to 14.0 in CI Aug 15, 2022
@Nayef211 Nayef211 marked this pull request as ready for review August 15, 2022 15:23
datumbox
datumbox approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

BTW TorchVision has switched directly to v14 back when it was beta and we didn't face any issues. I believe Andrey switched text to 12.5 just to be safe, but I think the latest shouldn't cause you any problems. Worth testing.

@Nayef211 Nayef211 merged commit 2fd12f3 into pytorch:main Aug 15, 2022
@Nayef211 Nayef211 deleted the hotfix/ci_macos_xcode_failure branch August 15, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datumbox datumbox datumbox approved these changes

@mthrok mthrok Awaiting requested review from mthrok

@NicolasHug NicolasHug Awaiting requested review from NicolasHug

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nayef211 @datumbox @facebook-github-bot