Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pkg_helpers.bash for PyTorch 1.13 release #1924

Open
wants to merge 1 commit into
base: release/0.14
Choose a base branch
from

Conversation

abhinavarora
Copy link
Contributor

No description provided.

Copy link
Contributor

@mthrok mthrok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necessary?

The current proposed change is touching the code path for nightly build. So I don't think this is correct.

Has something about the release process changed that require change in the bash script?

@abhinavarora
Copy link
Contributor Author

Why is this necessary?

The current proposed change is touching the code path for nightly build. So I don't think this is correct.

Has something about the release process changed that require change in the bash script?

Hey @mthrok I was just following the step 5 from this wiki. Please let me know if this is stale?

@mthrok
Copy link
Contributor

mthrok commented Oct 4, 2022

Can you rebase on #1923 and see if it makes difference? I believe it doesn’t make a difference but let’s see.

@mthrok
Copy link
Contributor

mthrok commented Oct 5, 2022

In the previous release, this change was made as a patch. But I believe that the correct fix is to make Arm Mac build job aware of PYTORCH_VERSION environment variable.

@facebook-github-bot
Copy link
Contributor

Hi @abhinavarora!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants