-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TorchData as hard dependency #1985
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added TORCHDATA_VERSION
against all the places with PYTORCH_VERSION
. But, I am not sure how build is going to use it for torchtext releases.
@Nayef211 @osalpekar In order to resolve this problem, I personally think it would be good to run |
@ejguan Thanks for the investigation - we can certainly source |
@ejguan PR is up: pytorch/test-infra#1073. Will monitor builds to ensure no existing builds are broken, but otherwise feel free to review/experiment with. |
77a3d8b
to
72d9b58
Compare
72d9b58
to
da23d3d
Compare
I think the failed test is unrelated to this PR. Edit: All tests passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks so much for taking care of adding the torchdata dependency @ejguan!
Per title
install_torchdata.sh
as the pre-script to installtorchdata
and specifyTORCHDATA_VERSION
andCONDA_TORCHDATA_CONSTRAINT
inBUILD_ENV_FILE