[BUG] Fix memory leak with Regex C++ operator #2024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GPT2BPETokenizer
increases as tokenization occurs only when special tokens are added. After further investigation, the reason for this is due to a memory leak from the additionalRegex
object that is created whenever special tokens have been added to the tokenizer class.text/torchtext/csrc/gpt2_bpe_tokenizer.cpp
Line 123 in 8c01462
text/torchtext/csrc/regex.cpp
Line 6 in 8c01462
Test Plan
After the fix, the memory footprint doesn't change with additional forward calls to the tokenizer.
Resolves #2020