Added min version requirements and README instructions for torchdata #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejguan
approved these changes
Feb 3, 2023
ejguan
reviewed
Feb 3, 2023
| @@ -19,7 +19,7 @@ Sphinx | |||
| pytest | |||
| expecttest | |||
| parameterized | |||
| torchdata | |||
| torchdata>0.5 | |||
There was a problem hiding this comment.
You might want to capture in your release runbook to update this version per release.
mthrok
approved these changes
Feb 3, 2023
|
@Nayef211 it looks like after this landed, many nightlies started failing due to |
|
@rshraga Thanks for reporting this. This is expected until the PyTorch nightly has been updated tmrw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking suggestions from @ejguan comments in #2045 (comment)
Closes #2047