Install portalocker for testing #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejguan
force-pushed
the
install_portalocker
branch
from
a2aeba0
to
ef9cd25
Compare
ejguan
force-pushed
the
install_portalocker
branch
from
ef9cd25
to
d91dceb
Compare
Nayef211
approved these changes
Feb 14, 2023
|
Shouldn't torch/text add an explicit dependency on portalocker now? Without it, I get: that's >80% failed tests, and probably does not represent a functional torchtext? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding this patch to minimize the hard dependency for TorchData. So,
portalockerwon't be automatically installed when installing withtorchdata.This PR would add
portalockerto ensure CI green