Optionally ignore utf-8 decoding error for scripted C++ tokenizers. (… #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ytorch#2128) Summary: Pull Request resolved: pytorch#2128 Binding and test to make sure we can use 'ignore' option for utf-8 decoding added to pytorch in D43970697( pytorch/pytorch#97282). Reviewed By: Nayef211 Differential Revision: D44315169 fbshipit-source-id: d42fcacafd429cf586c631faf826abc172b173d3
abhinavarora
approved these changes
Mar 29, 2023
joecummings
approved these changes
Mar 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #2134 +/- ##
============================
============================
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
You have successfully added a new CodeQL configuration |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…#2128)
Summary:
Pull Request resolved: #2128
Binding and test to make sure we can use 'ignore' option for utf-8 decoding added to pytorch in D43970697( pytorch/pytorch#97282).
Reviewed By: Nayef211
Differential Revision: D44315169
fbshipit-source-id: d42fcacafd429cf586c631faf826abc172b173d3