Use filelock library for file downloads
#2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Followup to D44604474 and D45048667. The previous 2 solutions didn't work because neither `iopath` nor `fcntl` implement platform agnostic locks. Thus the changes in the internal diffs could not be landed on github. Using [filelock](https://py-filelock.readthedocs.io/en/latest/index.html) should resolve the issue as it implements a platform agnostic file lock mechanism. This solution is also used by PyTorch Core to implement locking (see [code pointer](https://github.com/pytorch/pytorch/blob/bb830224e3e98732c8f26c1f179ff770f07fd543/torch/_inductor/codecache.py#L263-L268)). Reviewed By: debowin Differential Revision: D45234254 fbshipit-source-id: 2285f94b13e36685ec6a5c1c4d2cd74dee9e0431
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2166
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 PendingAs of commit 9cc4408: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Followup to D44604474 and D45048667. The previous 2 solutions didn't work because neither
iopathnorfcntlimplement platform agnostic locks. Thus the changes in the internal diffs could not be landed on github.Using filelock should resolve the issue as it implements a platform agnostic file lock mechanism. This solution is also used by PyTorch Core to implement locking (see code pointer).
Reviewed By: debowin
Differential Revision: D45234254
fbshipit-source-id: 2285f94b13e36685ec6a5c1c4d2cd74dee9e0431