Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NovaX] Remove CircleCI #2173

Merged
merged 5 commits into from
Jun 2, 2023
Merged

[NovaX] Remove CircleCI #2173

merged 5 commits into from
Jun 2, 2023

Conversation

osalpekar
Copy link
Member

@osalpekar osalpekar commented May 26, 2023

This PR removes most of the CircleCI directory. Primarily, this removes the CircleCI config files. These were the remaining jobs in the CCI configs:

  • Lint Jobs - these were migrated to Nova and removed from CCI by [NovaX] Lint Job on GHA #2151
  • Smoke Test docker build - AFAICT, this docker build is not used by anybody apart from a smoke test. We already have smoke tests running in the CircleCI jobs, release workflows, and the pytorch-wide validation workflows, so unlikely that these add any extra useful validation
  • StyleCheck Job - Defined but never called anywhere. For this reason, we did not migrate this to Nova.
  • CircleCI Consistency - Not Needed if there is no CCI config anymore.

We also removed the following:

In a follow-up, we can move the unittest scripts to the .github (or other) directory and remove the .circleci/ directory entirely.

@pytorch-bot
Copy link

pytorch-bot bot commented May 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/text/2173

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit fb89a4e:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@osalpekar osalpekar changed the title Remove Unused Docker build [NovaX] Remove Unused Docker build May 30, 2023
@osalpekar osalpekar changed the title [NovaX] Remove Unused Docker build [NovaX] Remove CircleCI Entirely May 30, 2023
@osalpekar osalpekar changed the title [NovaX] Remove CircleCI Entirely [NovaX] Remove CircleCI May 30, 2023
@osalpekar osalpekar merged commit 8546bbb into pytorch:main Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants