-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make vector loading more flexible. #353
Conversation
…limited by max_vectors
…hey are initialised
@notnami could you fix the issues Travis has with code style so this can be merged? (there's just a few indentations and unused imports) |
3418873
to
bc4590f
Compare
I fixed the issues with style, but now the Python 3.5 build has failed for an unclear reason. I believe that same build had passed before. Someone with write access to the repo could restart it, or I could close this PR and re-submit. |
@notnami I restarted it, probably just timed out. Will merge when it passes. |
@notnami thanks a lot! |
max_vectors
argument, in situations where the entire set of pre-trained vectors can't fit in memory (most pre-trained vector sets are sorted in the descending order of word frequency, so if you pass, say,max_vectors=100_000
, you will get pre-trained for 100_000 most common words)