Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestScriptableSP for Windows and include the relevant Windows tests online #799

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

mthrok
Copy link
Contributor

@mthrok mthrok commented May 28, 2020

No description provided.

@mthrok mthrok force-pushed the fix-sp-model-test-windows branch 2 times, most recently from 3c6783d to edcab79 Compare May 28, 2020 15:17
@mthrok mthrok marked this pull request as ready for review May 28, 2020 15:33
@mthrok mthrok force-pushed the fix-sp-model-test-windows branch from edcab79 to 0a24f96 Compare May 28, 2020 15:36
Copy link
Contributor

@zhangguanheng66 zhangguanheng66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have those Windows tests online.

@zhangguanheng66 zhangguanheng66 changed the title Fix TestScriptableSP for Windows Fix TestScriptableSP for Windows and include them online Jun 5, 2020
@zhangguanheng66 zhangguanheng66 changed the title Fix TestScriptableSP for Windows and include them online Fix TestScriptableSP for Windows and include the relevant Windows tests online Jun 5, 2020
@mthrok mthrok merged commit 7df4853 into pytorch:master Jun 5, 2020
@mthrok mthrok deleted the fix-sp-model-test-windows branch June 5, 2020 15:30
@mthrok
Copy link
Contributor Author

mthrok commented Jun 5, 2020

Thanks!

zhangguanheng66 pushed a commit to zhangguanheng66/text that referenced this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants