Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding dunder methods to cpp Vectors #852

Merged
merged 5 commits into from
Jun 26, 2020

Conversation

Nayef211
Copy link
Contributor

@Nayef211 Nayef211 commented Jun 25, 2020

Description

  • Updated cpp Vector methods with dunder methods
  • Now we can get and set elements in cpp Vectors class using [] operator
  • Updated teardown method in tests to work with the new registry names

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #852 into master will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
- Coverage   76.86%   76.85%   -0.02%     
==========================================
  Files          42       42              
  Lines        2944     2947       +3     
==========================================
+ Hits         2263     2265       +2     
- Misses        681      682       +1     
Impacted Files Coverage Δ
torchtext/experimental/vectors.py 86.23% <80.00%> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b887daa...5d94797. Read the comment docs.

@Nayef211 Nayef211 marked this pull request as ready for review June 26, 2020 18:33
@Nayef211 Nayef211 merged commit bcb9104 into pytorch:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants