Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pull 1034 Changes #1042

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Fix pull 1034 Changes #1042

merged 1 commit into from
Aug 19, 2024

Conversation

vmpuri
Copy link
Contributor

@vmpuri vmpuri commented Aug 19, 2024

Changes in pull #1034 were not the correct changes intended to land - local changes were not committed.

These changes are representative of what was tested in #1034 's description.

@vmpuri vmpuri requested a review from Jack-Khuu August 19, 2024 21:40
Copy link

pytorch-bot bot commented Aug 19, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1042

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e28c757 with merge base e3ec7ac (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 19, 2024
@vmpuri vmpuri force-pushed the openai_api_compatibility branch from 80f9223 to e28c757 Compare August 19, 2024 21:42
@vmpuri vmpuri marked this pull request as ready for review August 19, 2024 21:44
@vmpuri vmpuri merged commit 7d98090 into main Aug 19, 2024
51 checks passed
@vmpuri vmpuri mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants