Add Intel XPU device support to generate and serve

[jenniew]

Add XPU device support exclude distributed mode, workflow, documentation.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1361

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• GLIBC not found in Nova workflows

✅ No Failures

As of commit 4d16351 with merge base 2cf1a17 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[facebook-github-bot]

Hi @jenniew!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[mikekgfb]

Is there a way to run at least a few simple tests on an xpu to avoid inadvertent breakage?

[jenniew]

Is there a way to run at least a few simple tests on an xpu to avoid inadvertent breakage?

For generate, run a simple test by python3 torchchat.py generate llama3.1 --prompt "write me a story about a boy and his bear --device xpu
For serve, run a simple test by python3 torchchat.py server llama3.1 --device xpu

[Jack-Khuu]

Why does xpu need an older PYTORCH_NIGHTLY?

[jenniew]

when install torch==2.6.0.dev20241002 and torchvision==0.20.0.dev20241002+xpu, it will get error:
ERROR: Cannot install torch==2.6.0.dev20241002 and torchvision==0.20.0.dev20241002+xpu because these package versions have conflicting dependencies.

The conflict is caused by:
The user requested torch==2.6.0.dev20241002
torchvision 0.20.0.dev20241002+xpu depends on torch==2.6.0.dev20241001

So for xpu, I changed the torch nightly version to dev20241001

[Jack-Khuu]

Let me see if I can get you a fresher version on XPU, the torch/vision discrepancy shouldn't be a normal thing

[Jack-Khuu]

Context on the varying tune version?

[jenniew]

On xpu nightly URL, it does not have nightly version of torchtune, so just install 0.3.1 release for xpu environment.

[Jack-Khuu]

Hmm we should add support for nightly, let me ping some torchtune folk

cc: @ebsmothers

[Jack-Khuu]

Welcome to torchchat and thanks for adding @jenniew!!

Super stoked to see that it didn't require much lift to get XPU set up. Added a few questions on the versioning difference.
I'll try to get some folks to test and see if we can get some recurring jobs set up.

What device did you test on btw?

Tagging a few folk who I'm trying to help taking a larger role

[Jack-Khuu]

@jenniew Also do you mind filling out the CLA? It'll allow you to contribute to Meta repos

[jenniew]

@jenniew Also do you mind filling out the CLA? It'll allow you to contribute to Meta repos

Yes, I just signed the CLA

[jenniew]

Welcome to torchchat and thanks for adding @jenniew!!

Super stoked to see that it didn't require much lift to get XPU set up. Added a few questions on the versioning difference. I'll try to get some folks to test and see if we can get some recurring jobs set up.

What device did you test on btw?

Tagging a few folk who I'm trying to help taking a larger role

I tested on Intel Data Center GPU Max 1100.

[Jack-Khuu]

Just an update:

• I'm looking into getting a PT pin bumped Multi Pin Bumps across PT/AO/tune/ET #1367, which should allow XPU to use a fresher version
• https://github.com/pytorch/torchtune just release 0.4.0, which I'm asking someone to bump torchchat to so XPU can have an updated version over there as well

[mikekgfb]

Would be nice to run as a test as well. Could be as easy as enabling and adding a runner for xpu to test-readme-pr.yml if it is available. Alternatively, may require a copy of that file because the test spec has several target-runner related specs, with updates to all fields for values representative of xpu environment:

      runner: linux.g5.4xlarge.nvidia.gpu
      gpu-arch-type: cuda
      gpu-arch-version: "12.1"