Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install_requirements.sh to tune + pt/pt dev20241218 #1426

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

Jack-Khuu
Copy link
Contributor

@Jack-Khuu Jack-Khuu commented Dec 17, 2024

Note the pin bump of tune + fixed install requirements (was previously always using cuda 121 as extra-index)

Fixing: #1423


Note that this pin bump picks up failures on Linux AOTI cpp runners. Specifically the following tests fail:

  • runner-aoti
  • test-runner-aoti-cuda

Copy link

pytorch-bot bot commented Dec 17, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1426

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Pending

As of commit cb3ebe1 with merge base 113e40b (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 17, 2024
@Jack-Khuu Jack-Khuu added CI Infra Issues related to CI infrastructure and setup and removed CLA Signed This label is managed by the Meta Open Source bot. labels Dec 17, 2024
@Jack-Khuu
Copy link
Contributor Author

Looks like the nightly is missing on pytorch/pytorch for 1217 pytorch/pytorch#143434

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Dec 17, 2024
@Jack-Khuu
Copy link
Contributor Author

Jack-Khuu commented Dec 18, 2024

RuntimeError: operator torchvision::nms does not exist

Working with tune folk to debug failure:

  • Import succeeds on pt1213, but fails on 1218
  • Failure shows up on tune=1126 and 1218

Update: Fix with changing extra-index in installation

@Jack-Khuu Jack-Khuu added Llama 3.2- Multimodal Issues related to Multimodal of Llama3.2 torchtune Issue/PR related to torchtune components labels Dec 18, 2024
@Jack-Khuu Jack-Khuu changed the title Update install_requirements.sh to pt/pt dev20241217 Update install_requirements.sh to tune + pt/pt dev20241218 Dec 19, 2024
@Jack-Khuu Jack-Khuu merged commit fd1857a into main Dec 19, 2024
51 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Infra Issues related to CI infrastructure and setup CLA Signed This label is managed by the Meta Open Source bot. Llama 3.2- Multimodal Issues related to Multimodal of Llama3.2 torchtune Issue/PR related to torchtune components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants