Encoding: address some TODOs #667
Open
+39
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
NicolasHug
changed the title
NicolasHug
commented
Apr 30, 2025
| @@ -394,8 +394,6 @@ void encode_audio_to_file( | |||
| .encode(); | |||
| } | |||
|
|
|||
| // TODO-ENCODING is "format" a good parameter name?? It kinda conflicts with | |||
| // "sample_format" which we may eventually want to expose. | |||
There was a problem hiding this comment.
torchaudio.load() uses format as well, so I think that's fine. We haven't discussed the public API yet anyway.
NicolasHug
changed the title
scotts
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a few outstanding TODO-ENCODING entries. See diff for (hopefully obvious!) changes.