Assertion to check if fake tensors have leaked into python #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine, but tests are failing |
eellison
approved these changes
Oct 3, 2022
|
Yes, the goal was to run CI to uncover any such issues. Happy that CI uncovered atleast one. It seems to be Fake tensor issue as well. We should fix that one. |
eellison
reviewed
Oct 4, 2022
anijain2305
force-pushed
the
add_asertion
branch
from
641e505 to
17f9650
Compare
anijain2305
force-pushed
the
add_asertion
branch
from
17f9650 to
740130c
Compare
|
@jansel Can you please review again as I added some Update - Removed the eq code because.I later realized that dataclasses have |
jansel
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am seeing a fake tensor in
frame.f_localswhich is confusing to me. And I think this is wrong. Fake tensor is internal, and when someone runs a graph with real inputs, none of the output should be a FakeTensor.So, adding an assertion to catch it somewhat early to help debug and share some repros.