Implement torch.Tensor APIs for TorchRec wrappers #3096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

iamzainhuda wants to merge 1 commit into pytorch:main from iamzainhuda:export-D75553113

Contributor

iamzainhuda commented Jun 13, 2025

Summary:

Diff Context

Sometime trainer state_dict input to checkpointing can contain LocalShardsWrapper from TorchRec, which is a torch.Tensor. However, it doesn't implement some torch.Tensor operations like copy_, zeros_like, empty_like. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

facebook-github-bot added the fb-exported label

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 0d288a2 to 150c77a Compare

June 13, 2025 20:18

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

150c77a

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

Contributor

facebook-github-bot commented Jun 13, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

f09b8db

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 150c77a to f09b8db Compare

June 13, 2025 23:53

Contributor

facebook-github-bot commented Jun 14, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

464243f

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from f09b8db to 464243f Compare

June 14, 2025 19:28

Contributor

facebook-github-bot commented Jun 16, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 464243f to 84f7ba1 Compare

June 16, 2025 15:47

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

84f7ba1

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

Contributor

facebook-github-bot commented Jun 16, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

54685ae

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 84f7ba1 to 54685ae Compare

June 16, 2025 16:49

Contributor

facebook-github-bot commented Jun 16, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 54685ae to ab508e6 Compare

June 16, 2025 18:20

Contributor

facebook-github-bot commented Jun 16, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

57f0fbc

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from ab508e6 to 57f0fbc Compare

June 16, 2025 19:09

Contributor

facebook-github-bot commented Jun 16, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

5f24435

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 57f0fbc to 5f24435 Compare

June 16, 2025 22:11

Contributor

facebook-github-bot commented Jun 16, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

2d00c7e

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 5f24435 to 2d00c7e Compare

June 16, 2025 23:29

pradeepfn approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Jun 17, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 2d00c7e to 2f4ccba Compare

June 17, 2025 21:08

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

2f4ccba

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda, pradeepfn

Differential Revision: D75553113

Contributor

facebook-github-bot commented Jun 17, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

3785db9

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda, pradeepfn

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 2f4ccba to 3785db9 Compare

June 17, 2025 23:08

Contributor

facebook-github-bot commented Jun 18, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

df2b385

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda, pradeepfn

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from 3785db9 to df2b385 Compare

June 18, 2025 15:08

Contributor

facebook-github-bot commented Jun 18, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda pushed a commit to iamzainhuda/torchrec that referenced this pull request


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

f2ad463

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda, pradeepfn

Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from df2b385 to f2ad463 Compare

June 18, 2025 17:35


          Implement torch.Tensor APIs for TorchRec wrappers (pytorch#3096)

012d1fc

Summary:
Pull Request resolved: pytorch#3096

### Diff Context
Sometime trainer `state_dict` input to checkpointing can contain `LocalShardsWrapper` from TorchRec, which is a `torch.Tensor`. However, it doesn't implement some `torch.Tensor` operations like `copy_`, `zeros_like`, `empty_like`. This diff aims to implement those.

Reviewed By: iamzainhuda, pradeepfn

Differential Revision: D75553113

Contributor

facebook-github-bot commented Jun 18, 2025

This pull request was exported from Phabricator. Differential Revision: D75553113

iamzainhuda force-pushed the export-D75553113 branch from f2ad463 to 012d1fc Compare

June 18, 2025 17:49

facebook-github-bot closed this in

f126ded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported