Skip to content

Commit 82b593e

Browse files
authored
remove dead code (#1501)
Summary: remove some stale code that determines parameters to pass to outer optimizer --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1501). * #1446 * #1502 * __->__ #1501
1 parent be49c02 commit 82b593e

File tree

1 file changed

+0
-2
lines changed
  • torchtitan/components

1 file changed

+0
-2
lines changed

torchtitan/components/ft.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,6 @@ def maybe_semi_sync_training(
123123
), "FTManager must be enabled to use semi-sync training."
124124
if semi_sync_method.lower() == "diloco":
125125
# Create the outer optimizer based on the inner optimizer parameters.
126-
params = [group["params"] for group in optimizer.param_groups]
127-
params = [param for sublist in params for param in sublist]
128126
outer_optimizers = []
129127
for model in model_parts:
130128
params = [p for p in model.parameters() if p.requires_grad]

0 commit comments

Comments
 (0)