remove dead code #1501
Merged
remove dead code #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: remove some stale code that determines parameters to pass to outer optimizer
tushar00jain
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
This was referenced Jul 31, 2025
meta-cla
bot
added
the
CLA Signed
tianyu-l
approved these changes
Jul 31, 2025
tushar00jain
added a commit
that referenced
this pull request
Jul 31, 2025
Summary: the leaf folder wasn't being created so and no profiles were being written, so create it if it doesn't exist --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1502). * #1446 * __->__ #1502 * #1501
bentherien
pushed a commit
to bentherien/torchtitan_
that referenced
this pull request
Aug 5, 2025
Summary: remove some stale code that determines parameters to pass to outer optimizer --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1501). * pytorch#1446 * pytorch#1502 * __->__ pytorch#1501
bentherien
pushed a commit
to bentherien/torchtitan_
that referenced
this pull request
Aug 5, 2025
Summary: the leaf folder wasn't being created so and no profiles were being written, so create it if it doesn't exist --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1502). * pytorch#1446 * __->__ pytorch#1502 * pytorch#1501
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
Summary: remove some stale code that determines parameters to pass to outer optimizer --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1501). * pytorch#1446 * pytorch#1502 * __->__ pytorch#1501
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
Summary: the leaf folder wasn't being created so and no profiles were being written, so create it if it doesn't exist --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1502). * pytorch#1446 * __->__ pytorch#1502 * pytorch#1501
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
Summary: remove some stale code that determines parameters to pass to outer optimizer --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1501). * pytorch#1446 * pytorch#1502 * __->__ pytorch#1501
joellidin
pushed a commit
to one-covenant/torchtitan
that referenced
this pull request
Aug 8, 2025
Summary: the leaf folder wasn't being created so and no profiles were being written, so create it if it doesn't exist --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/torchtitan/pull/1502). * pytorch#1446 * __->__ pytorch#1502 * pytorch#1501
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
remove some stale code that determines parameters to pass to outer optimizer
Stack created with Sapling. Best reviewed with ReviewStack.