Remove self.topk in ReordererSequenceParallel to prevent mutation #1873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmhst7
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
meta-cla
bot
added
the
CLA Signed
tianyu-l
reviewed
Oct 14, 2025
| local_rank = device_mesh.get_local_rank() | ||
| # fact: top_scores.shape[0] // self.top_k = batch_size * seq_len // ep_degree | ||
| token_indices_experts_sorted += top_scores.shape[0] // self.top_k * local_rank | ||
| token_indices_experts_sorted += top_scores.shape[0] // mod.top_k * local_rank |
Contributor
There was a problem hiding this comment.
Could you please add a raise ValueError if mod doesn't have top_k attribute, with meaningful error message?
Co-authored-by: tianyu-l <150487191+tianyu-l@users.noreply.github.com>
tianyu-l
approved these changes
Oct 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1806 (comment)
This PR prevents mutation of ReordererSequenceParallel. Because torch.utils.checkpoint.checkpoint is a HOP and has such constraint.